Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js sanetize DOM Text Interpreted As HTML #4361

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Shivam7-1
Copy link

Description

Sanitize HTML content using DOMPurify before returning it in richContent. This ensures safe rendering of potentially untrusted HTML, protecting against XSS attacks. The innerHTML of the first child node is sanitized before being returned, improving security.

@Shivam7-1
Copy link
Author

Hii @glo82145 Team Could You Please Review This PR
Thanks

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Dec 7, 2024

Fails
🚫 A version label is required. A maintainer must add one.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 Missing "Verification Steps" section. Please add it back, with detail.
Messages
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against b05f8cc

@Shivam7-1
Copy link
Author

Hii @glo42707 @@glo82145 Could Team Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hii @glo42707 @@glo82145 Could Team Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hii @engcom-Hotel @engcom-Charlie Could Team Please Review This PR also if possible
Thanks

@engcom-Hotel
Copy link

Hello @glo42707, we request you to please look into this PR.

@Shivam7-1
Copy link
Author

Shivam7-1 commented Dec 18, 2024

Hii @glo42707 @glo82145 Could You Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hii @glo82145 I had updated Dependencies here also Could You please Review this
Regards

@Shivam7-1
Copy link
Author

Hii @engcom-Hotel @engcom-Charlie Could Team Please ping Reviewers again
Thanks

@Shivam7-1
Copy link
Author

Hii @glo82145 @glo42707 Could Team also Test this PR
Thanks

@glo82145
Copy link
Collaborator

Please run command 'yarn run prettier venia-integration-tests/src/fixtures/googleMapApi/index.js' on your local and commit the changes. There is a prettier fail with this file.

@Shivam7-1
Copy link
Author

Shivam7-1 commented Dec 23, 2024

Hii @glo82145
Done This
Now here below automated pr-test has passed now
image

@Shivam7-1
Copy link
Author

Hii @glo82145 Thanks For Reviewing
Is there anything else is Required From my side to get this PR merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants