-
Notifications
You must be signed in to change notification settings - Fork 462
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
51 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# CHANGELOG | ||
|
||
## Master (Unreleased) | ||
|
||
## 0.14.0 - 2016-07-29 | ||
|
||
### Added | ||
|
||
* Rails 5 compatibility. | ||
|
||
### Fixed | ||
|
||
* `Mailboxer::Message` object no longer requires to have a subject. | ||
* Objects are now saved before mails are sent, you you can use them in the | ||
mailer templates (to build URLs, for example). | ||
|
||
### Changed | ||
|
||
* Errors are now stored in the parent message/notification instead of being | ||
stored in the sender receipt. That means you need handle mailboxer related | ||
controller and views differently, and study the upgrade case by case (propably | ||
by having a look at mailboxer's source code). As an example, if you were | ||
previously doing something like this in your controller: | ||
|
||
``` | ||
@receipt = @actor.send_message(@recipients, params[:body], params[:subject]) | ||
if (@receipt.errors.blank?) | ||
@conversation = @receipt.conversation | ||
redirect_to conversation_path(@conversation) | ||
else | ||
render :action => :new | ||
end | ||
``` | ||
|
||
you now need to do something like | ||
|
||
``` | ||
@receipt = @actor.send_message(@recipients, params[:body], params[:subject]) | ||
@message = @receipt.message | ||
if (@message.errors.blank?) | ||
@conversation = @message.conversation | ||
redirect_to conversation_path(@conversation) | ||
else | ||
render :action => :new | ||
end | ||
``` | ||
|
||
This might look more complicated at first but allows you to build more RESTful | ||
resources since you can build forms on messages and/or conversations and | ||
directly show errors on them. Less specially handling is now required to | ||
propagate errors around models. |