MF-20 - Refactor service #41
Conversation
| @@ -16,27 +16,40 @@ const ( | |||
| device = "device" | |||
There was a problem hiding this comment.
Why do we have folder services, and in it service.go? Are these local services on the gateway?
It is a little confusing, because we have service.go which relates to agent and then services which relate to local services...
There was a problem hiding this comment.
But I currently have no better idea for naming.
There was a problem hiding this comment.
can we rename service.go to agent.go
or maybe services/info.go
There was a problem hiding this comment.
Well... I am more bothered about the folder name services. I think we should rename service.go into agent.go for sure, and we can leave this services for now, but we need to document it somewhere - maybe add one README.md in the agent or these services folder...
There was a problem hiding this comment.
for the folder maybe info, or stats so we have info/service.go
or maybe since it is basically only for heartbeat to call it heartbeat/service.go
Signed-off-by: Mirko Teodorovic <[email protected]>
Signed-off-by: Mirko Teodorovic <[email protected]>
Signed-off-by: Mirko Teodorovic <[email protected]>
Signed-off-by: Mirko Teodorovic <[email protected]>
Signed-off-by: Mirko Teodorovic <[email protected]>
mteodor
force-pushed
the
refactor-service
branch
from
538bb41 to
79395d9
Compare
pkg/agent/heartbeat.go
Outdated
| @@ -16,27 +16,40 @@ const ( | |||
| device = "device" | |||
| ) | |||
|
|
|||
| type Service struct { | |||
| type svc struct { | |||
| name string | |||
There was a problem hiding this comment.
This looks very similar to Info{} - maybe one struct should contain another?
Signed-off-by: Mirko Teodorovic <[email protected]>
Signed-off-by: Mirko Teodorovic <[email protected]>
Signed-off-by: Mirko Teodorovic <[email protected]>
pkg/agent/heartbeat.go
Outdated
| // Whenservice doesnt send heartbeat for some time gets marked offline | ||
| type svc struct { | ||
| info Info | ||
|
|
Signed-off-by: Mirko Teodorovic <[email protected]>
| for { | ||
| select { | ||
| case <-s.ticker.C: | ||
| // TODO - we can disable ticker when the status gets OFFLINE |
There was a problem hiding this comment.
Can you create an issue for this please?
closes #20