Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to vendor openssl #17

Open
tshepang opened this issue Jun 6, 2020 · 3 comments · May be fixed by #18
Open

Add feature to vendor openssl #17

tshepang opened this issue Jun 6, 2020 · 3 comments · May be fixed by #18

Comments

@tshepang
Copy link

tshepang commented Jun 6, 2020

To help build more portable executables, it would be nice to have an option to build against a vendored openssl version.

At the moment, I have to do the following myself, even though openssl is a transitive dependency:

# This is a hack, to force openssl to be built statically.
# It's a dependency of crypto-hash.
[dependencies.openssl]
version = "0.10"
features = ["vendored"]
@malept
Copy link
Owner

malept commented Jun 6, 2020

Can you explain why this is a hack?

@tshepang
Copy link
Author

tshepang commented Jun 6, 2020

Am controlling how a transitive dep is built, and that makes it look like I depend directly on it. Would be better if there was a cargo feature (in crypto-hash) to choose.

@malept malept changed the title allow to build a vendored openssl Add feature to vendor openssl Jun 6, 2020
@malept
Copy link
Owner

malept commented Jun 6, 2020

I'm happy to take a pull request for this. Please make sure that it gets documented in the README, too.

tshepang added a commit to tshepang/crypto-hash that referenced this issue Jun 6, 2020
tshepang added a commit to tshepang/crypto-hash that referenced this issue Jun 6, 2020
@tshepang tshepang linked a pull request Jun 6, 2020 that will close this issue
tshepang added a commit to tshepang/crypto-hash that referenced this issue Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants