Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to vendor openssl #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

tshepang
Copy link

@tshepang tshepang commented Jun 6, 2020

Closes #17

Copy link
Owner

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, but I'm not sure how this change can be tested in CI.

README.md Show resolved Hide resolved
@malept
Copy link
Owner

malept commented Jun 8, 2020

For some reason this isn't triggering a Travis CI build, which is required for this particular change. I'll need to find some time to figure out why that is.

@malept
Copy link
Owner

malept commented Jun 8, 2020

It did, but it's not showing up as a GitHub check?

There's a linting issue in the main branch: https://travis-ci.org/github/malept/crypto-hash/jobs/695853671 - I'll fix when I find some time.

@tshepang
Copy link
Author

tshepang commented Jun 8, 2020

Looks tiny... let me fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to vendor openssl
2 participants