Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base PNGs made seamless - apologies to Vincent #2

Merged
merged 2 commits into from
Aug 23, 2014

Conversation

wboykinm
Copy link
Contributor

Should remove tile edge artifacts from the map once sprite-ed.

@mapmeld
Copy link
Owner

mapmeld commented Aug 23, 2014

looks good! holds true to the original intent & probably will look much better

  • is there a sprite-making tool which you'd recommend? I might be doing a bunch of projects like this
  • when I paste into sprite.png, Not all of the images had the same size, so I set the X dimension to the width of the first image. I'll have to adjust things to keep your images seamless

@wboykinm
Copy link
Contributor Author

I haven't actually built sprites before, and I'm loathe to just make a new one and undo all your coordinate-referencing work in the .json files. Let me add a sprite to this PR anyway though . . .

@mapmeld
Copy link
Owner

mapmeld commented Aug 23, 2014

@wboykinm that would be amazing! I've got time to fix up the JSON file later today.

@wboykinm
Copy link
Contributor Author

Here's the CSS issued for the new seamless sprite; hopefully that's helpful with the JSON generating.

.sprite { background: url('sprite.png') no-repeat top left;  } 
.sprite.city { background-position: 0px 0px; width: 444px; height: 195px;  } 
.sprite.farm { background-position: 0px -195px; width: 444px; height: 412px;  } 
.sprite.snow { background-position: 0px -607px; width: 444px; height: 157px;  } 
.sprite.grass { background-position: 0px -764px; width: 444px; height: 394px;  } 
.sprite.water { background-position: 0px -1158px; width: 444px; height: 225px;  } 
.sprite.rock { background-position: 0px -1383px; width: 444px; height: 470px;  } 
.sprite.wood { background-position: 0px -1853px; width: 444px; height: 346px;  } 

image

mapmeld added a commit that referenced this pull request Aug 23, 2014
base PNGs made seamless - apologies to Vincent
@mapmeld mapmeld merged commit bb651b3 into mapmeld:gh-pages Aug 23, 2014
@mapmeld
Copy link
Owner

mapmeld commented Aug 23, 2014

Looks good. I'll merge and take a few minutes to get this live

@mapmeld
Copy link
Owner

mapmeld commented Aug 23, 2014

I think you got it! Made my last couple of edits and tried it out on my retina screen. Just awesome.

@wboykinm
Copy link
Contributor Author

Sweeeeeeeet. I see some edge artifacts are still coming through; I bet they're related to tile size and dimension. It may be that true seamlessness only comes with 256x256 and 512x512 PNGs. Maybe @rsudekum has thoughts on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants