-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add speed factor sensor #208
feat: add speed factor sensor #208
Conversation
b42f0a6
to
c1260e9
Compare
@TheJefe please 👁️ the tests |
c1260e9
to
e690319
Compare
e690319
to
1848898
Compare
@marcolivierarsenault , sorry for the delay, but I fixed the tests |
To fix formating make sure pre-commit hook works. else you can run black manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you have black
pass and
add some test for your new sensors.
(AKA, add parameters to test_sensors
in test_sensors.py file.)
adding
("mainsail_speed_factor", "200.0"),
should do the trick
Thanks for the guidance @marcolivierarsenault ! I've made the requested updates |
This look great, will do final review and merge later this weekend |
62f3775
into
marcolivierarsenault:main
Thank you @TheJefe |
Description
This PR adds a simple speed_factor sensor
API Documentation: https://www.klipper3d.org/Status_Reference.html#gcode_move
Additionally, It is maybe worth noting that I am using a Sonic Pad, and having no issues with this project
Testing
Tested on my local HA setup, works exactly as expected
Other
Not included in this PR, I added some macros and buttons to adjust the speed factor