Skip to content
This repository has been archived by the owner on Jun 26, 2018. It is now read-only.

DP-8645 remove nbsp from decorative links #787

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified backstopjs/reference/regression_page_event_0_document_0_phone.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified backstopjs/reference/regression_page_service_0_document_0_phone.png
Binary file modified backstopjs/reference/regression_page_topic_0_document_0_phone.png
3 changes: 3 additions & 0 deletions changelogs/DP-8645.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Changed
Patch
- DP-8645: Remove non-breaking space from decorative link markup
2 changes: 1 addition & 1 deletion styleguide/source/_patterns/01-atoms/decorative-link.twig
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
<a
href="{{decorativeLink.href}}"
class="js-clickable-link"
title="{{ decorativeLink.info }}">{{decorativeLink.text}}&nbsp;{{ icon('arrow') }}</a>
title="{{ decorativeLink.info }}">{{decorativeLink.text}}{{ icon('arrow') }}</a>
</span>
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
// applied to the container holding the a tag
// adds a underline on hover
// prevents the external or arrow icon from becoming an orphan
// basic structure expected => <div><a>text&nbsp;<svg></svg></a></div>
// basic structure expected => <div><a>text&nbsp;<svg></svg></a></div>

@mixin ma-link-decorative {
padding-right: .8em;

a {
@include ma-link-underline;
Expand All @@ -13,8 +12,8 @@
svg {
display: inline-block;
height: .6em;
margin-right: -.8em;
width: .6em;
margin-left: 0.25em;
}
}
}
4 changes: 2 additions & 2 deletions styleguide/source/assets/scss/03-organisms/_icon-links.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
&__icon {
font-size: 0;
position: absolute;
top: 5px;
left: 0;
top: 8px;
left: 0;

& > svg {
height: 18px;
Expand Down