Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default get_njobs_in_queue behavior #542

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

esoteric-ephemera
Copy link

@esoteric-ephemera esoteric-ephemera commented Jan 28, 2025

The get_njobs_in_queue function of CommonAdapter was recently updated in v2.0.4 to use shell=True all the time when calling qstat. That seems to not work in practice, as running:

python -c 'from fireworks.user_objects.queue_adapters.common_adapter import CommonAdapter ; print(CommonAdapter("SLURM").get_njobs_in_queue())'

returns say thousands of jobs, which is the total number of jobs running in the queue, rather than the number I expect to see. (Specifying the username explicitly also doesn't work.)

Just making this optional, with the default behavior set to shell=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant