-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev json logs #22994
Open
krezreb
wants to merge
13
commits into
5.x-dev
Choose a base branch
from
dev-json-logs
base: 5.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev json logs #22994
+86
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@krezreb please fix the PHPCS style check first. Referece: https://innocraft.atlassian.net/wiki/spaces/DE/pages/2395570181/Create+a+Github+action+to+check+if+code+formatting+is+as+per+PSR+standard |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Modifies the LineMessageFormatter to support outputting of log messages as json (one json object per line). This has a number of benefits for observability:
Also adds support for customers to add custom json processing to each line (useful for example for adding APM trace and span ids in for Datadog Unified service tagging users)
Review
Depends on plugin PR matomo-org/plugin-LogViewer#99
To test json_logs
config/config.ini.php
setenable_json = true
(see example below)index.php?module=LogViewer
logs should appear correctly in the interfaceTo test exclude_pattens
config/config.ini.php
set one or more exclude_patterns, separated by pipes(see example below)To test custom_function_file
config/config.ini.php
specify custom_function_file (see example below)custom.php