docs: explain windows 10 alg limitation #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because windows 10 only supports RS256, it's not supported by our ES256 verifier, so until we add an RS256 verifier this platform won't work. We've attempted to limit these sign-ups via the browser, but it doesn't appear to stop users from choosing that option. Documenting it is the next best thing, but we'll probably add a more explicit error next.
|
Visit the preview URL for this PR (updated for commit 3a7b637): https://zksync-docs-staging-5eb09--pr258-sso-windows-piio5gy1.web.app (expires Tue, 26 Nov 2024 02:21:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11 |
popzxc
approved these changes
Nov 19, 2024
|
🎉 This PR is included in version 1.44.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because windows 10 only supports RS256, it's not supported by our ES256
verifier, so until we add an RS256 verifier this platform won't work.
We've attempted to limit these sign-ups via the browser, but it doesn't
appear to stop users from choosing that option. Documenting it is the
next best thing, but we'll probably add a more explicit error next.
Linked Issues
https://github.com/matter-labs/zksync-account-sdk/issues/182
Additional context
The current NFT demo (as of this writing) will also fail for Windows 11, so it requires a small update so these docs are correct