Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Windows 10 Hello doesn't throw a descripive error message #6

Open
cpb8010 opened this issue Nov 19, 2024 · 0 comments
Open

[Bug]: Windows 10 Hello doesn't throw a descripive error message #6

cpb8010 opened this issue Nov 19, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cpb8010
Copy link
Contributor

cpb8010 commented Nov 19, 2024

🧰 Project

SDK

📝 Description

The SDK expects an ES256 key from the webauthn APIs and when it's not in that expected format, the SDK fails and no descriptive error message is returned to the user. We know we can't support passkeys that aren't using ES256, so we can provide a much more descriptive error message if we can't prevent the browser from returning data that we can't use!

🔄 Reproduction steps

On a windows 10 machine, use the Windows Hello PIN or facial recognition options to create a passkey in the auth server creation page. You'll get a generic error, and the console logs will show that we're expecting a value that doesn't exist in the passkey data.

🤔 Expected behavior

We return an error message that says something to the effect of "We don't support Windows 10 Hello, try any other passkey provider!"

😯 Actual behavior

People think it's broken and they can't sign up.

🖥 Environment

Windows 10 or Windows 11 before the 2022 update.

📋 Additional context

Eventually we might want to support RS256 and Windows Hello for Windows 10, but for now it's not a high priority since we expect most users will want to use their mobile devices for passkeys due to their portability and integrated backup options.

📎 Logs

DqOc5i10.js:1  DataError: The JWK "n" member contained a leading zero.
@cpb8010 cpb8010 added the bug Something isn't working label Nov 19, 2024
@cpb8010 cpb8010 self-assigned this Nov 19, 2024
@itsacoyote itsacoyote transferred this issue from matter-labs/zksync-sso-clave-contracts Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant