Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching Callback Routes for Load and Uninstall #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VitaliJud
Copy link

All 3 routes were using the same callback url - /auth/install which was failing to load the app.

Copy link
Owner

@matthewvolk matthewvolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thank you for the PR! Just one quick fix if you don't mind 😄

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @VitaliJud ! This all looks good, but do you mind removing this file from the PR? I want to make sure VSCode settings are added explicitly by the user instead of automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants