fix: handle translations

mauricerenck · Nov 15, 2024 · 7f409d5 · 7f409d5
1 parent 5389cf9
commit 7f409d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/index.php b/index.php
@@ -33,10 +33,10 @@
         ],
         [
             'pattern' => ['(:all)/og-image', 'og-image'],
-            'language' => '*',
-            'action' => function ($lang, $slug) {
+            'action' => function ($slug) {
                 $languages = kirby()->languages();
                 $language = null;
+
                 if (count($languages) > 1) {
                     $language = null;
                     $slugParts = explode('/', $slug);
@@ -48,7 +48,7 @@
                 }
 
                 $languageString = is_null($language) ? 'default' : $language;
-                $page = ($slug == '/' || $slug == 'og-image') ? site()->homePage() : $page = page($slug);
+                $page = ($slug == '/' || $slug == 'og-image') ? site()->homePage() : page($slug);
 
                 if (!$page) {
                     return new Response('Page "' . $slug . '" not found', 'text/plain', 404);

diff --git a/lib/page-methods.php b/lib/page-methods.php
@@ -47,9 +47,16 @@
             return;
         }
 
+        if ($language == 'default') {
+            $title = $this->{$titleField}()->isNotEmpty() ? $this->{$titleField}() : $this->title();
+        } else {
+            $translation = $this->translation($language);
+            $content = $translation->content();
+            $title = !empty($content[$titleField]) ? $content[$titleField] : $content['title'];
+        }
+
         $canvas = imagecreatetruecolor($imageWidth, $imageHeight);
         $textColor = imagecolorallocate($canvas, $fontColor[0], $fontColor[1], $fontColor[2]);
-        $title = $this->{$titleField}()->isNotEmpty() ? $this->{$titleField}() : $this->title();
         $templateImage = imagecreatefrompng($templateImagePath);
 
         $backgroundFile = !is_null($this->{$heroImageField}()) && $this->{$heroImageField}()->isNotEmpty()