Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix budget money formatting #1626

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented Jan 17, 2025

This PR fixes a few cases where budgets are not displaying values in the family currency.

In addition, this PR disables the ability for the user to change their family currency after onboarding:

  • Changing family currency requires all accounts, transactions, and budgets to be converted to the new currency
  • We will need a "migration" flow in the future (see Create family currency migration flow #1627) to allow the user to switch family currency, which will includes several bulk updates to their data. For now, to avoid confusion, disabling currency changes is the most straightforward option.

@zachgoll zachgoll merged commit ca8bdb6 into main Jan 17, 2025
6 checks passed
@zachgoll zachgoll deleted the zachgoll/budget-currency-constraint branch January 17, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant