Clean up some TODOs

mbbsemu · Oct 7, 2024 · dc0471b · dc0471b
1 parent a61f57c
commit dc0471b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/btrieve/BtrieveDatabase.cc b/btrieve/BtrieveDatabase.cc
@@ -621,7 +621,6 @@ void BtrieveDatabase::getVariableLengthData(
 
   if (recordType == RecordType::VariableTruncated) {
     for (uint16_t i = 0; i < truncatedBytes; ++i) {
-      // TODO - instead of pushing space, should it be database's nullChar?
       stream.push_back(' ');
     }
   }

diff --git a/btrieve/BtrieveDriver.cc b/btrieve/BtrieveDriver.cc
@@ -29,7 +29,6 @@ static inline bool fileExists(const tchar *filename,
     return false;
   }
 
-  // TODO check this
   fileModificationNanos =
       *reinterpret_cast<int64_t *>(&fileAttributeData.ftLastWriteTime);
   return true;

diff --git a/vstudio/wbtrv32/wbtrv32.cpp b/vstudio/wbtrv32/wbtrv32.cpp
@@ -247,8 +247,7 @@ static BtrieveError Stat(BtrieveCommand &command) {
       lpKeySpec->position = segment.getPosition();
       lpKeySpec->length = segment.getLength();
       lpKeySpec->attributes = segment.getAttributes();
-      lpKeySpec->uniqueKeys =
-          btrieveDriver->getRecordCount();  // TODO do I need to calculate this?
+      lpKeySpec->uniqueKeys = btrieveDriver->getRecordCount();
       lpKeySpec->extendedDataType = segment.getDataType();
       lpKeySpec->nullValue = segment.getNullValue();
       lpKeySpec->reserved = 0;
@@ -319,7 +318,6 @@ static BtrieveError GetPosition(BtrieveCommand &command) {
   *reinterpret_cast<uint32_t *>(command.lpDataBuffer) =
       btrieveDriver->getPosition();
 
-  // TODO can this be InvalidPositioning, say on an empty file?
   return BtrieveError::Success;
 }
 
@@ -560,7 +558,6 @@ static BtrieveError Create(BtrieveCommand &command) {
       acsName[0] = 0;
     }
 
-    // TODO figure out segment stuff later
     KeyDefinition keyDefinition(
         i, static_cast<uint16_t>(lpKeySpec->length),
         static_cast<uint16_t>(lpKeySpec->position) - 1,

diff --git a/vstudio/wbtrv32/wbtrv32.vcxproj b/vstudio/wbtrv32/wbtrv32.vcxproj
@@ -130,7 +130,7 @@
       <SubSystem>Windows</SubSystem>
       <EnableCOMDATFolding>true</EnableCOMDATFolding>
       <OptimizeReferences>true</OptimizeReferences>
-      <GenerateDebugInformation>false</GenerateDebugInformation>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
       <EnableUAC>false</EnableUAC>
       <ModuleDefinitionFile>wbtrv32.def</ModuleDefinitionFile>
       <AdditionalDependencies>Rpcrt4.lib;$(CoreLibraryDependencies);%(AdditionalDependencies)</AdditionalDependencies>
@@ -179,7 +179,7 @@
       <SubSystem>Windows</SubSystem>
       <EnableCOMDATFolding>true</EnableCOMDATFolding>
       <OptimizeReferences>true</OptimizeReferences>
-      <GenerateDebugInformation>false</GenerateDebugInformation>
+      <GenerateDebugInformation>true</GenerateDebugInformation>
       <EnableUAC>false</EnableUAC>
       <ModuleDefinitionFile>wbtrv32.def</ModuleDefinitionFile>
       <AdditionalDependencies>Rpcrt4.lib;$(CoreLibraryDependencies);%(AdditionalDependencies)</AdditionalDependencies>