Merge pull request #669 from mcneel/AndyPayne/Compute-290

Fixes Compute-290. Bumping Hops version number to 0.16.9
mcneel · Jul 3, 2024 · 7afbc28 · 7afbc28
2 parents 7b41bda + bb6e170
commit 7afbc28
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.HOPS.md b/CHANGELOG.HOPS.md
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.16.9] - 2024-07-03
+
+### Fixed
+
+- Fixed a bug where setting the environment variable RHINO_COMPUTE_DEBUG to True would not in effect add any additional logging information to the console output. The default for this is True when running in debug mode, and False when running Rhino.Compute in release mode. Override this setting by creating an environment variable called RHINO_COMPUTE_DEBUG and setting the value to True or False. Note, this change will only work when targeting builds of Rhino >= 8.10.
+
 ## [0.16.8] - 2024-06-05
 
 ### Fixed
@@ -12,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- A few additional lines of logging information were added to display the the current build of Rhino.Compute and Rhino as well as the working system path. 
+- A few additional lines of logging information were added to display the the current build of Rhino.Compute and Rhino as well as the working system path.
 
 ## [0.16.7] - 2024-04-22
 

diff --git a/src/compute.geometry/Startup.cs b/src/compute.geometry/Startup.cs
@@ -46,15 +46,17 @@ public void Configure(IApplicationBuilder app)
         void RhinoCoreStartup()
         {
             Program.RhinoCore = new Rhino.Runtime.InProcess.RhinoCore(null, Rhino.Runtime.InProcess.WindowStyle.NoWindow);
+
+            if (Config.Debug)
+                Rhino.RhinoApp.SendWriteToConsole = true;
+
             Environment.SetEnvironmentVariable("RHINO_TOKEN", null, EnvironmentVariableTarget.Process);
             Rhino.Runtime.HostUtils.OnExceptionReport += (source, ex) =>
             {
                 Log.Error(ex, "An exception occurred while processing request");
                 Logging.LogExceptionData(ex);
             };
 
-            Rhino.RhinoApp.SendWriteToConsole = true;
-
             // NOTE:
             // eirannejad 10/02/2024 (COMPUTE-268)
             // Ensure RhinoCode plugin (Rhino plugin) is loaded. This plugin registers scripting
@@ -95,7 +97,6 @@ void RhinoCoreStartup()
             if (runheadless != null)
                 runheadless.Invoke(pluginObject, null);
 
-            Rhino.RhinoApp.SendWriteToConsole = false;
 
             Log.Information("(3/3) Loading compute plug-ins");
             var loadComputePlugins = typeof(Rhino.PlugIns.PlugIn).GetMethod("LoadComputeExtensionPlugins");

diff --git a/src/hops/Properties/AssemblyInfo.cs b/src/hops/Properties/AssemblyInfo.cs
@@ -28,7 +28,7 @@ public GhaAssemblyInfo()
             TheAssemblyInfo = this;
         }
 
-        public const string AppVersion = "0.16.8.0";
+        public const string AppVersion = "0.16.9.0";
 
         public override Bitmap Icon
         {