Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: simplify options API #6

Merged
merged 2 commits into from
Dec 5, 2023
Merged

refactor!: simplify options API #6

merged 2 commits into from
Dec 5, 2023

Conversation

mcous
Copy link
Owner

@mcous mcous commented Dec 5, 2023

Before:

when(spy).calledWith("hello").thenReturn("world", ONCE)

After:

when(spy, { times: 1 }).calledWith("hello").thenReturn("world")

@mcous mcous changed the title feat!: try out a more straightforward options API refactor!: simplify options API Dec 5, 2023
@mcous mcous force-pushed the better-options-api branch from 58452ea to bec7dde Compare December 5, 2023 01:19
@mcous mcous force-pushed the better-options-api branch from bec7dde to d37a24a Compare December 5, 2023 01:21
@mcous mcous merged commit 9d1b256 into main Dec 5, 2023
22 checks passed
@mcous mcous deleted the better-options-api branch December 5, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcous