Signal middleware #313
Open
Signal middleware #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add config example - add logging of used middlewares (to verify if for eg. Signal config was parsed correctly) - fix signal config in README.md
Open
|
Taking into account that bbernhard/signal-cli-rest-api is a self-hosted API wrapper around CLI, I'm not sure if it would make sense to create dedicated middleware for. Especially is API is as simple as $ curl -X POST -H "Content-Type: application/json" 'http://localhost:8080/v2/send' \
-d '{"message": "Test via Signal API!", "number": "+4412345", "recipients": [ "+44987654" ]}'I don't want ofelia to end up with integration with dozens of APIs. Instead I'm wondering maybe building generic HTTP middleware with examples on how to use specific services will be better long term. See discussion in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Signal middleware with https://github.com/bbernhard/signal-cli-rest-api usage. Approach copied from slack implementation.
Tested on my fork.
I am using that daily.