Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployer): migrate to dependency groups #12516

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Jan 25, 2025

Summary

  • replace the deprecated "poetry.dev-dependencies" section for poetry
  • Make the dev dependencies optional, so those dependencies will not be installed in mdn/content, mdn/translated-content CIs.

Problem

The "poetry.dev-dependencies" section has been deprecated: https://python-poetry.org/blog/announcing-poetry-1.2.0/

Solution

Replace the section with dev group


How did you test this change?

Run the following command to check the installation:

  • poetry install
  • poetry install --with dev

Verified

This commit was signed with the committer’s verified signature.
yin1999 A1lo
…tion

Verified

This commit was signed with the committer’s verified signature.
yin1999 A1lo

Verified

This commit was signed with the committer’s verified signature.
yin1999 A1lo
@yin1999 yin1999 requested a review from a team as a code owner January 25, 2025 04:32
@github-actions github-actions bot added dependencies Pull requests that update a dependency file deployer Deployment (currently using AWS S3 and AWS Lambda) github-actions labels Jan 25, 2025

Verified

This commit was signed with the committer’s verified signature.
yin1999 A1lo
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jan 27, 2025
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@caugner
Copy link
Contributor

caugner commented Jan 27, 2025

Replace the section with dev group

@yin1999 Did you make the changes manually, or is there a poetry command to achieve this?

@yin1999
Copy link
Member Author

yin1999 commented Jan 27, 2025

Replace the section with dev group

@yin1999 Did you make the changes manually, or is there a poetry command to achieve this?

I manually replace the section, following the note.

Make the dev group optional by manually adding the section [tool.poetry.group.docs] (follow the section).

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@caugner caugner changed the title chore(deployer): replace the deprecated "poetry.dev-dependencies" section for poetry chore(deployer): migrate to dependency groups Jan 27, 2025
@caugner
Copy link
Contributor

caugner commented Jan 27, 2025

@yin1999 Can you take a look at the merge conflicts?

Verified

This commit was signed with the committer’s verified signature.
yin1999 A1lo
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jan 28, 2025
@yin1999
Copy link
Member Author

yin1999 commented Jan 28, 2025

@yin1999 Can you take a look at the merge conflicts?

Resolved.

Verified

This commit was signed with the committer’s verified signature.
yin1999 A1lo
@caugner caugner merged commit 57d1385 into mdn:main Jan 30, 2025
13 checks passed
@yin1999 yin1999 deleted the poetry-dev branch January 30, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deployer Deployment (currently using AWS S3 and AWS Lambda) github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants