Skip to content
This repository has been archived by the owner on Dec 14, 2023. It is now read-only.

[RFR] remove crimson hexagon references #793

Merged
merged 3 commits into from
Jul 12, 2021
Merged

[RFR] remove crimson hexagon references #793

merged 3 commits into from
Jul 12, 2021

Conversation

jtotoole
Copy link
Contributor

@jtotoole jtotoole commented Jun 23, 2021 •
edited
Loading

Decided to make a fresh PR rather than fight my way out of merge commit hell on #785.

Does adding select insert_platform_source_pair( 'twitter', 'brandwatch' ); here in mediawords.sql entail a migration, and should I also delete select insert_platform_source_pair( 'twitter', 'crimson_hexagon' );?

@jtotoole jtotoole requested a review from pypt June 23, 2021 00:29
@jtotoole jtotoole changed the title remove crimson hexagon references [WIP] remove crimson hexagon references Jun 23, 2021
@jtotoole jtotoole changed the title [WIP] remove crimson hexagon references [RFR] remove crimson hexagon references Jul 1, 2021
@jtotoole
Copy link
Contributor Author

jtotoole commented Jul 1, 2021

@pypt now we're in business (RFR = Ready For Review).

jtotoole
jtotoole commented Jul 2, 2021
View reviewed changes
apps/crawler-fetcher/tests/python/test_podcast_resolve_url.py
@@ -34,21 +34,21 @@ def test_get_feed_url_from_google_podcasts_url():
assert _get_feed_url_from_google_podcasts_url('http://www.example.com/') == 'http://www.example.com/'
assert _get_feed_url_from_google_podcasts_url('totally not an URL') == 'totally not an URL'

npr_feed_url = 'https://feeds.npr.org/381444908/podcast.xml'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feed url seems to oscillate at times for no reason, so hopefully the FT one will be more stable

@pypt
Copy link
Contributor

pypt commented Jul 2, 2021

Does adding select insert_platform_source_pair( 'twitter', 'brandwatch' ); here in mediawords.sql entail a migration, and should I also delete select insert_platform_source_pair( 'twitter', 'crimson_hexagon' );?

I think it does - that function preloads the table with some platform-source pairs, so you might want to DELETE from the table that it preloads into to get rid of that deprecated platform-source pair.

@pypt
Copy link
Contributor

pypt commented Jul 2, 2021

I think it does - that function preloads the table with some platform-source pairs, so you might want to DELETE from the table that it preloads into to get rid of that deprecated platform-source pair.

...and all of the rows in other tables with reference that particular row in topic_sources.

@jtotoole
Copy link
Contributor Author

jtotoole commented Jul 2, 2021

...so you might want to DELETE from the table that it preloads into to get rid of that deprecated platform-source pair

Would it be okay to do that in a separate PR once the pgmigrate one gets merged?

@jtotoole jtotoole mentioned this pull request Jul 2, 2021
Merged
@pypt pypt merged commit 4bd46ad into master Jul 12, 2021
@pypt
Copy link
Contributor

pypt commented Jul 12, 2021

Very cool, thank you! Down with CH!

@pypt pypt deleted the jot-delete-chexagon branch July 12, 2021 21:23
@pypt pypt mentioned this pull request Jul 12, 2021
Open
@pypt
Copy link
Contributor

pypt commented Jul 12, 2021

Would it be okay to do that in a separate PR once the pgmigrate one gets merged?

Sure, moved this to #798,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pypt pypt Awaiting requested review from pypt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtotoole @pypt