Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use localized name for screen instead of number #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: use localized name for screen instead of number #1

wants to merge 1 commit into from

Conversation

b4s36t4
Copy link

@b4s36t4 b4s36t4 commented Jan 30, 2025

@algora-pbc algora-pbc bot mentioned this pull request Jan 30, 2025
Closed
@b4s36t4
Copy link
Author

b4s36t4 commented Jan 30, 2025

Screenshot 2025-01-31 at 4 29 28 AM

@ologbonowiwi
Copy link

nice! I can confirm it works
image

two things tho:

  1. the PR should be open on https://github.com/nashaofu/xcap, to close issue get actual monitor display name nashaofu/xcap#185
  2. the same should be done for other OSes, namely Windows and Linux

@b4s36t4
Copy link
Author

b4s36t4 commented Jan 31, 2025

I'm not sure, but as per the code they were using names instead of any model numbers. I'm not sure but I think we're good there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b4s36t4 @ologbonowiwi