Feature: Implementation of createMany lifecycle hook #972

Ra0R · 2024-11-04T14:53:48Z

Pull Request

Implemented createMany-Hook that is available sinceStrapi v4.9.0, the createMany()-Lifecycle hook properly returns a count and a set of ids after creation.
Test of the implemented function also extended mock to properly test behaviour
Bumped peerDependencies to "peerDependencies": { "@strapi/strapi": "^4.9.0" }

Related issue

Fixes #965
Probably fixes #399 (I am not sure how tasks are updated upon restart)

What does this PR do?

...

PR checklist

Please check if your PR fulfills the following requirements:

Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
Have you read the contributing guidelines?
However, I could not lint since there would be changes in 67 to remove carriage-returns( error Delete ␍ prettier/prettier )
Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

…ad of creating a single update task for every document

… introduced in @strapi/strapi: 4.9.0

Ra0R · 2024-11-04T15:18:46Z

@brunoocasali Looking forward to your review.

dosomder · 2024-11-13T18:37:22Z

@brunoocasali Any news on this? This would be an important change also for the company I am working at

brunoocasali · 2024-11-25T19:32:36Z

Hi folks! I just merged the support for strapi v5 #964, which made this PR outdated. Can you fix those conflicts?

Ra0R · 2024-11-26T07:06:33Z

Hi folks! I just merged the support for strapi v5 #964, which made this PR outdated. Can you fix those conflicts?

Hey Bruno, We can address these changes. Regardless, I think these changes should've been merged and released in a minor version of the plugin. Since some people might not be able to upgrade to Strapi v5 and (correct me) the newer plugin version will not be compatible with Strapi v4?

brunoocasali · 2024-11-26T12:55:41Z

You're right :/

Even if the plugin is compatible, users could have other plugins blocking their upgrade. So, if we want to provide the feature to both cases, we would need to provide two different releases.

If you're willing to do it, we can do that!

I would ask you to open another PR pointing to the HEAD before the last merge v0.12.0. Then, I can release it as v0.12.1.

brunoocasali · 2024-11-26T12:58:35Z

server/src/services/lifecycle/lifecycle.js

+          const ids = result.ids
+
+          const entries = []
+          const BATCH_SIZE = 500


Can you transform this into a customizable param that people could choose from in the plugin initializer?

This is a hard limit given by strapis sql engine when compiling a query (or the database im not sure).

server/src/services/meilisearch/connector.js

Co-authored-by: Bruno Casali <[email protected]>

brunoocasali · 2024-12-11T12:04:19Z

bors merge

brunoocasali

LGTM! 🎉

Thanks a lot for your PR! If you want to release it for v4, you can create a PR like I mentioned earlier!

curquiza

bors merge

curquiza · 2024-12-11T13:41:48Z

@Ra0R, sorry, can you rebase? Looks like we cannot merge with our tool (bug) and the branch is out dated, but I don't know why I cannot update it 😢

So, can you rebase (or pull main) so that we can merge manually?

Bumps the production group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | @strapi/design-system | `2.0.0-rc.11` | `2.0.0-rc.14` | | @strapi/icons | `2.0.0-rc.11` | `2.0.0-rc.14` | | [meilisearch](https://github.com/meilisearch/meilisearch-js) | `0.42.0` | `0.45.0` | | [@strapi/sdk-plugin](https://github.com/strapi/sdk-plugin) | `5.2.6` | `5.2.7` | | [@strapi/strapi](https://github.com/strapi/strapi) | `5.0.1` | `5.4.1` | Updates `@strapi/design-system` from 2.0.0-rc.11 to 2.0.0-rc.14 Updates `@strapi/icons` from 2.0.0-rc.11 to 2.0.0-rc.14 Updates `meilisearch` from 0.42.0 to 0.45.0 - [Release notes](https://github.com/meilisearch/meilisearch-js/releases) - [Commits](meilisearch/meilisearch-js@v0.42.0...v0.45.0) Updates `@strapi/sdk-plugin` from 5.2.6 to 5.2.7 - [Release notes](https://github.com/strapi/sdk-plugin/releases) - [Changelog](https://github.com/strapi/sdk-plugin/blob/main/CHANGELOG.md) - [Commits](strapi/sdk-plugin@v5.2.6...v5.2.7) Updates `@strapi/strapi` from 5.0.1 to 5.4.1 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.1) --- updated-dependencies: - dependency-name: "@strapi/design-system" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production - dependency-name: "@strapi/icons" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production - dependency-name: meilisearch dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production - dependency-name: "@strapi/sdk-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: production - dependency-name: "@strapi/strapi" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: production ... Signed-off-by: dependabot[bot] <[email protected]>

curquiza · 2024-12-31T08:26:25Z

@Ra0R this is weird, there are commits in your branch (related to strapi v5) that should not be here.
Can you try the rebase again? Or remove the commits manually?

thank you again for the PR

Ra0R · 2024-12-31T08:38:06Z

@curquiza I merged main into the feature branch.

curquiza · 2024-12-31T09:29:23Z

@Ra0R can you rebase instead of pulling? I created a guide here to do it.
https://gist.github.com/curquiza/5f7ce615f85331f083cd467fc4e19398

Sorry for the inconvenience

…ad of creating a single update task for every document

Co-authored-by: Bruno Casali <[email protected]>

Bumps the production group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | @strapi/design-system | `2.0.0-rc.11` | `2.0.0-rc.14` | | @strapi/icons | `2.0.0-rc.11` | `2.0.0-rc.14` | | [meilisearch](https://github.com/meilisearch/meilisearch-js) | `0.42.0` | `0.45.0` | | [@strapi/sdk-plugin](https://github.com/strapi/sdk-plugin) | `5.2.6` | `5.2.7` | | [@strapi/strapi](https://github.com/strapi/strapi) | `5.0.1` | `5.4.1` | Updates `@strapi/design-system` from 2.0.0-rc.11 to 2.0.0-rc.14 Updates `@strapi/icons` from 2.0.0-rc.11 to 2.0.0-rc.14 Updates `meilisearch` from 0.42.0 to 0.45.0 - [Release notes](https://github.com/meilisearch/meilisearch-js/releases) - [Commits](meilisearch/meilisearch-js@v0.42.0...v0.45.0) Updates `@strapi/sdk-plugin` from 5.2.6 to 5.2.7 - [Release notes](https://github.com/strapi/sdk-plugin/releases) - [Changelog](https://github.com/strapi/sdk-plugin/blob/main/CHANGELOG.md) - [Commits](strapi/sdk-plugin@v5.2.6...v5.2.7) Updates `@strapi/strapi` from 5.0.1 to 5.4.1 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.1) --- updated-dependencies: - dependency-name: "@strapi/design-system" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production - dependency-name: "@strapi/icons" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: production - dependency-name: meilisearch dependency-type: direct:production update-type: version-update:semver-minor dependency-group: production - dependency-name: "@strapi/sdk-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: production - dependency-name: "@strapi/strapi" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: production ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the playground group in /playground with 26 updates: | Package | From | To | | --- | --- | --- | | [@strapi/plugin-users-permissions](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/strapi](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [meilisearch](https://github.com/meilisearch/meilisearch-js) | `0.36.0` | `0.45.0` | | [@strapi/admin](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/cloud-cli](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/content-manager](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/content-releases](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/content-type-builder](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/core](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | @strapi/data-transfer | `5.0.1` | `5.4.2` | | [@strapi/database](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | @strapi/design-system | `2.0.0-rc.11` | `2.0.0-rc.13` | | [@strapi/email](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/generators](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/i18n](https://github.com/strapi/strapi/tree/HEAD/packages/plugins/i18n) | `5.0.1` | `5.4.2` | | @strapi/icons | `2.0.0-rc.11` | `2.0.0-rc.13` | | [@strapi/logger](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/permissions](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/provider-email-sendmail](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/provider-upload-local](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/review-workflows](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/types](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/typescript-utils](https://github.com/strapi/strapi/tree/HEAD/packages/utils/typescript) | `5.0.1` | `5.4.2` | | @strapi/ui-primitives | `2.0.0-rc.11` | `2.0.0-rc.13` | | [@strapi/upload](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | | [@strapi/utils](https://github.com/strapi/strapi) | `5.0.1` | `5.4.2` | Updates `@strapi/plugin-users-permissions` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/strapi` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `meilisearch` from 0.36.0 to 0.45.0 - [Release notes](https://github.com/meilisearch/meilisearch-js/releases) - [Commits](meilisearch/meilisearch-js@v0.36.0...v0.45.0) Updates `@strapi/admin` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/cloud-cli` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/content-manager` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/content-releases` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/content-type-builder` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/core` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/data-transfer` from 5.0.1 to 5.4.2 Updates `@strapi/database` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/design-system` from 2.0.0-rc.11 to 2.0.0-rc.13 Updates `@strapi/email` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/generators` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/i18n` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](https://github.com/strapi/strapi/commits/v5.4.2/packages/plugins/i18n) Updates `@strapi/icons` from 2.0.0-rc.11 to 2.0.0-rc.13 Updates `@strapi/logger` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/permissions` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/provider-email-sendmail` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/provider-upload-local` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/review-workflows` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/types` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/typescript-utils` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](https://github.com/strapi/strapi/commits/v5.4.2/packages/utils/typescript) Updates `@strapi/ui-primitives` from 2.0.0-rc.11 to 2.0.0-rc.13 Updates `@strapi/upload` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) Updates `@strapi/utils` from 5.0.1 to 5.4.2 - [Release notes](https://github.com/strapi/strapi/releases) - [Commits](strapi/strapi@v5.0.1...v5.4.2) --- updated-dependencies: - dependency-name: "@strapi/plugin-users-permissions" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/strapi" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: playground - dependency-name: meilisearch dependency-type: direct:production update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/admin" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/cloud-cli" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/content-manager" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/content-releases" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/content-type-builder" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/core" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/data-transfer" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/database" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/design-system" dependency-type: indirect update-type: version-update:semver-patch dependency-group: playground - dependency-name: "@strapi/email" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/generators" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/i18n" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/icons" dependency-type: indirect update-type: version-update:semver-patch dependency-group: playground - dependency-name: "@strapi/logger" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/permissions" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/provider-email-sendmail" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/provider-upload-local" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/review-workflows" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/types" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/typescript-utils" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/ui-primitives" dependency-type: indirect update-type: version-update:semver-patch dependency-group: playground - dependency-name: "@strapi/upload" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground - dependency-name: "@strapi/utils" dependency-type: indirect update-type: version-update:semver-minor dependency-group: playground ... Signed-off-by: dependabot[bot] <[email protected]>

…Tacture/strapi-plugin-meilisearch into feat/create-many-lifecycle-hook

Ra0R · 2025-01-02T09:25:31Z

@curquiza I rebased onto main (I hope I did it correctly).

brunoocasali · 2025-01-06T14:09:44Z

bors merge

meili-bors · 2025-01-06T14:12:26Z

Build succeeded:

Ra0R added 9 commits November 4, 2024 14:12

feat(lifecycle): implemented afterCreateMany hook with

42979bf

feat(connector): update entries now batches documents to update inste…

157b3ac

…ad of creating a single update task for every document

chore: Bumped peer dependency on strapi, createMany-hook changes were…

381908f

… introduced in @strapi/strapi: 4.9.0

test(connector): Added test for update entries

e8f1210

feat(connector): Improved readability and properly return task ids

310fa5a

fix(connector): take correct id, removed console log

60e7128

test: added mock function and test documentDelete in update function

3c005f1

fix: removed console log

a0e02df

fix: removed unused import

d4da7f2

Ra0R changed the title ~~Feat/create many lifecycle hook~~ Feature: Implementation of createMany lifecycle hook Nov 4, 2024

Ra0R marked this pull request as draft November 4, 2024 15:01

Ra0R marked this pull request as ready for review November 10, 2024 14:17

Merge branch 'main' into feat/create-many-lifecycle-hook

f09a597

brunoocasali self-requested a review November 25, 2024 19:32

brunoocasali added the enhancement New feature or request label Nov 25, 2024

Merge branch 'main' into feat/create-many-lifecycle-hook

00da198

brunoocasali reviewed Nov 26, 2024

View reviewed changes

Update server/src/services/meilisearch/connector.js

2f39dd2

Co-authored-by: Bruno Casali <[email protected]>

brunoocasali previously approved these changes Dec 11, 2024

View reviewed changes

curquiza previously approved these changes Dec 11, 2024

View reviewed changes

meili-bot and others added 3 commits December 11, 2024 14:58

Update package.json

91fbc19

Update package.json

29f86e3

Merge branch 'main' into feat/create-many-lifecycle-hook

953228d

Ra0R and others added 21 commits January 2, 2025 10:07

feat(lifecycle): implemented afterCreateMany hook with

90b68ed

feat(connector): update entries now batches documents to update inste…

d07d0bc

…ad of creating a single update task for every document

test(connector): Added test for update entries

340f030

feat(connector): Improved readability and properly return task ids

7a0cba9

fix(connector): take correct id, removed console log

b7d794d

test: added mock function and test documentDelete in update function

0edc735

fix: removed console log

38758e5

Update server/src/services/meilisearch/connector.js

28bb84e

Co-authored-by: Bruno Casali <[email protected]>

Update package.json

dd37615

Update package.json

63475b6

Add support to Strapi v5 in docs

5ee3cc0

Add npm run build before publishing

a78d5b0

Fix pkg with npm command

d838d30

Update package.json for next release

ff97dfc

Add yarn install first

1ba45fe

Update package.json

3cec030

Update package.json

df8b3af

Update package.json for next release

8fc1b2f

Merge branch 'feat/create-many-lifecycle-hook' of https://github.com/…

14918c8

…Tacture/strapi-plugin-meilisearch into feat/create-many-lifecycle-hook

brunoocasali approved these changes Jan 6, 2025

View reviewed changes

meili-bors bot merged commit 210fa04 into meilisearch:main Jan 6, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Implementation of createMany lifecycle hook #972

Feature: Implementation of createMany lifecycle hook #972

Ra0R commented Nov 4, 2024 •

edited

Loading

Ra0R commented Nov 4, 2024

dosomder commented Nov 13, 2024

brunoocasali commented Nov 25, 2024

Ra0R commented Nov 26, 2024

brunoocasali commented Nov 26, 2024

brunoocasali Nov 26, 2024

Ra0R Nov 27, 2024

brunoocasali commented Dec 11, 2024

brunoocasali left a comment •

edited

Loading

curquiza left a comment

curquiza commented Dec 11, 2024

curquiza commented Dec 31, 2024 •

edited

Loading

Ra0R commented Dec 31, 2024

curquiza commented Dec 31, 2024 •

edited

Loading

Ra0R commented Jan 2, 2025

brunoocasali commented Jan 6, 2025

meili-bors bot commented Jan 6, 2025

Feature: Implementation of createMany lifecycle hook #972

Feature: Implementation of createMany lifecycle hook #972

Conversation

Ra0R commented Nov 4, 2024 • edited Loading

Pull Request

Related issue

What does this PR do?

PR checklist

Ra0R commented Nov 4, 2024

dosomder commented Nov 13, 2024

brunoocasali commented Nov 25, 2024

Ra0R commented Nov 26, 2024

brunoocasali commented Nov 26, 2024

brunoocasali Nov 26, 2024

Choose a reason for hiding this comment

Ra0R Nov 27, 2024

Choose a reason for hiding this comment

brunoocasali commented Dec 11, 2024

brunoocasali left a comment • edited Loading

Choose a reason for hiding this comment

curquiza left a comment

Choose a reason for hiding this comment

curquiza commented Dec 11, 2024

curquiza commented Dec 31, 2024 • edited Loading

Ra0R commented Dec 31, 2024

curquiza commented Dec 31, 2024 • edited Loading

Ra0R commented Jan 2, 2025

brunoocasali commented Jan 6, 2025

meili-bors bot commented Jan 6, 2025

Ra0R commented Nov 4, 2024 •

edited

Loading

brunoocasali left a comment •

edited

Loading

curquiza commented Dec 31, 2024 •

edited

Loading

curquiza commented Dec 31, 2024 •

edited

Loading