-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update mount.blacklist -> mount.ignorelist #2245
base: master
Are you sure you want to change the base?
Conversation
Merging these commits will result in the following changelog entries: Changelogsmeta-mender (fix-udev-extraconf-rule)New changes in meta-mender since master:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mirzak - weird that this went unnoticed for so long 😩
@mirzak Can you please sign your commit? Then I will run the pipeline and get this one merged and ported to the supported branches. |
6d8e362
to
8b7acb0
Compare
@lluiscampos, it should be signed now? But I think it was originally as well. Not sure what it is complaining about in check commits. |
This was updated a while back in [1]. 1. https://git.openembedded.org/openembedded-core/commit/meta/recipes-core/udev/udev-extraconf_1.1.bb?id=69e486ddb3059f80ba538e1f59c2ca8a8df0faf9 Changelog: Prevent secondary rootfs from being mounted by udev-extraconf. Ticket: None Signed-off-by: Mirza Krak <[email protected]>
Maybe I read it wrong the first time (sorry), but now I can see the issue: the "Changelog" and "Title" are supposed to be at the end according to our (rather strict) commit checker. I fixed it for you. Thanks again for your contribution! |
8b7acb0
to
c653fe8
Compare
@lluiscampos, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can trigger GitHub->GitLab branch sync with:
You can cherry pick to a given branch or branches with:
|
@mender-test-bot start pipeline |
Hello 😺 I created a pipeline for you here: Pipeline-1633899162 Build Configuration Matrix
|
This was updated a while back in [1]. Odd that this has gone unnoticed for so long?
Changelog: Prevent secondary rootfs from being mounted by udev-extraconf.
[1]. https://git.openembedded.org/openembedded-core/commit/meta/recipes-core/udev/udev-extraconf_1.1.bb?id=69e486ddb3059f80ba538e1f59c2ca8a8df0faf9
External Contributor Checklist
🚨 Please review the guidelines for contributing to this repository.
The majority of our contributions are fixes, which means your commit should have
the form below:
git --signoff
. Also note that the signoff author must match the author of the commit.Description
Please describe your pull request.
Thank you!