Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mount.blacklist -> mount.ignorelist #2245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mirzak
Copy link
Contributor

@mirzak mirzak commented Jan 16, 2025

This was updated a while back in [1]. Odd that this has gone unnoticed for so long?

Changelog: Prevent secondary rootfs from being mounted by udev-extraconf.

[1]. https://git.openembedded.org/openembedded-core/commit/meta/recipes-core/udev/udev-extraconf_1.1.bb?id=69e486ddb3059f80ba538e1f59c2ca8a8df0faf9

External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

  • Make sure that all commits follow the conventional commit specification for the Mender project.

The majority of our contributions are fixes, which means your commit should have
the form below:

fix: <SHORT DESCRIPTION OF FIX>

<OPTIONAL LONGER DESCRIPTION>

Changelog: <USER-FRIENDLY-CHANGE-DESCRIPTION> or <None>
Ticket: <TICKET NUMBER> or <None>
  • Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description

Please describe your pull request.

Thank you!

@mender-test-bot
Copy link

Merging these commits will result in the following changelog entries:

Changelogs

meta-mender (fix-udev-extraconf-rule)

New changes in meta-mender since master:

  • Prevent secondary rootfs from being mounted by udev-extraconf.

Copy link
Contributor

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mirzak - weird that this went unnoticed for so long 😩

@lluiscampos
Copy link
Contributor

@mirzak Can you please sign your commit? Then I will run the pipeline and get this one merged and ported to the supported branches.

@lluiscampos lluiscampos self-assigned this Jan 20, 2025
@mirzak mirzak force-pushed the fix-udev-extraconf-rule branch 2 times, most recently from 6d8e362 to 8b7acb0 Compare January 20, 2025 13:02
@mirzak
Copy link
Contributor Author

mirzak commented Jan 20, 2025

@lluiscampos, it should be signed now? But I think it was originally as well. Not sure what it is complaining about in check commits.

This was updated a while back in [1].

1. https://git.openembedded.org/openembedded-core/commit/meta/recipes-core/udev/udev-extraconf_1.1.bb?id=69e486ddb3059f80ba538e1f59c2ca8a8df0faf9

Changelog: Prevent secondary rootfs from being mounted by udev-extraconf.
Ticket: None

Signed-off-by: Mirza Krak <[email protected]>
@lluiscampos
Copy link
Contributor

@lluiscampos, it should be signed now? But I think it was originally as well. Not sure what it is complaining about in check commits.

Maybe I read it wrong the first time (sorry), but now I can see the issue: the "Changelog" and "Title" are supposed to be at the end according to our (rather strict) commit checker.

I fixed it for you. Thanks again for your contribution!

@lluiscampos lluiscampos force-pushed the fix-udev-extraconf-rule branch from 8b7acb0 to c653fe8 Compare January 21, 2025 09:08
@mender-test-bot
Copy link

@lluiscampos, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline".


my commands and options

You can trigger a pipeline on multiple prs with:

  • mentioning me and start pipeline --pr mender/127 --pr mender-connect/255

You can start a fast pipeline, disabling full integration tests with:

  • mentioning me and start pipeline --fast

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@lluiscampos
Copy link
Contributor

@mender-test-bot start pipeline

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-1633899162

Build Configuration Matrix

Key Value
BUILD_BEAGLEBONEBLACK true
BUILD_CLIENT true
BUILD_QEMUX86_64_BIOS_GRUB true
BUILD_QEMUX86_64_BIOS_GRUB_GPT true
BUILD_QEMUX86_64_UEFI_GRUB true
BUILD_VEXPRESS_QEMU true
BUILD_VEXPRESS_QEMU_FLASH true
BUILD_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true
META_MENDER_REV pull/2245/head
RUN_INTEGRATION_TESTS true
TEST_QEMUX86_64_BIOS_GRUB true
TEST_QEMUX86_64_BIOS_GRUB_GPT true
TEST_QEMUX86_64_UEFI_GRUB true
TEST_VEXPRESS_QEMU true
TEST_VEXPRESS_QEMU_FLASH true
TEST_VEXPRESS_QEMU_UBOOT_UEFI_GRUB true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants