forked from snowcap/Emarsys
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part 2] Modernise code #92
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
96b9107
Start rectoring everything
ryanmab 202269c
Run more general code hygiene rector rules
ryanmab bdce5a1
Run rector in CI
ryanmab fa6588d
Run rector on phpunit tests
ryanmab 768e482
Add type declarations to sets and bump to phpunit 10
ryanmab 7761575
Remove verbose option for phpunit runs
ryanmab 8237522
Make sure rector is run in dry run mode
ryanmab 4965787
Update authors
ryanmab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,11 @@ | |
"ext-json": "*" | ||
}, | ||
"require-dev": { | ||
"phpunit/phpunit": "^9", | ||
"phpunit/phpunit": "^10", | ||
"php-http/mock-client": "^1.4.1", | ||
"guzzlehttp/guzzle": "^7.0.1", | ||
"http-interop/http-factory-guzzle": "^1.0.0" | ||
"http-interop/http-factory-guzzle": "^1.0.0", | ||
"rector/rector": "^1.0" | ||
}, | ||
"minimum-stability": "stable", | ||
"config": { | ||
|
@@ -30,7 +31,8 @@ | |
} | ||
}, | ||
"scripts": { | ||
"test": "phpunit tests/ --verbose" | ||
"test": "phpunit tests/", | ||
"rector": "rector --dry-run" | ||
}, | ||
"license": "MIT", | ||
"authors": [ | ||
|
@@ -39,8 +41,8 @@ | |
"email": "[email protected]" | ||
}, | ||
{ | ||
"name": "Alex Oanea", | ||
"email": "alex.oanea@mention-me.com" | ||
"name": "Ryan Maber", | ||
"email": "ryan.maber@mention-me.com" | ||
} | ||
] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely controversial! 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the most important part of this PR! 😜