Changed template create/update REST call from POST to PUT #3521

mercedes-benz · Dec 5, 2024 · de70eb3 · de70eb3
1 parent 110ce3a
commit de70eb3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/...-doc/src/test/java/com/mercedesbenz/sechub/restdoc/TemplateRestControllerRestDocTest.java b/...-doc/src/test/java/com/mercedesbenz/sechub/restdoc/TemplateRestControllerRestDocTest.java
@@ -121,7 +121,7 @@ public void restdoc_admin_creates_or_updates_template() throws Exception {
 
         /* execute + test @formatter:off */
 		this.mockMvc.perform(
-			post(apiEndpoint, TEST_TEMPLATE_ID1).
+			put(apiEndpoint, TEST_TEMPLATE_ID1).
 			contentType(MediaType.APPLICATION_JSON_VALUE).
 	        content(content).
 	        header(AuthenticationHelper.HEADER_NAME, AuthenticationHelper.getHeaderValue())

diff --git a/sechub-integrationtest/src/main/java/com/mercedesbenz/sechub/integrationtest/api/AsUser.java b/sechub-integrationtest/src/main/java/com/mercedesbenz/sechub/integrationtest/api/AsUser.java
@@ -1433,7 +1433,7 @@ public SecHubEncryptionStatus fetchEncryptionStatus() {
 
     public AsUser createOrUpdateTemplate(String templateId, TemplateDefinition definition) {
         String url = getUrlBuilder().buildAdminCreatesOrUpdatesTemplate(templateId);
-        getRestHelper().postJson(url, definition.toFormattedJSON());
+        getRestHelper().putJSON(url, definition.toFormattedJSON());
         return this;
     }
 

diff --git a/sechub-openapi-java/src/main/resources/openapi.yaml b/sechub-openapi-java/src/main/resources/openapi.yaml
@@ -3918,7 +3918,7 @@ paths:
         - Other
 
   /api/admin/template/{templateId}:
-    post:
+    put:
       summary: Admin creates or updates a template
       description: An administrator wants to create a new template or to update a template definition
       operationId: adminCreateOrUpdateTemplate

diff --git a/...an/src/main/java/com/mercedesbenz/sechub/domain/scan/template/TemplateRestController.java b/...an/src/main/java/com/mercedesbenz/sechub/domain/scan/template/TemplateRestController.java
@@ -45,7 +45,7 @@ public class TemplateRestController {
     LogSanitizer logSanitizer;
 
     @UseCaseAdminCreatesOrUpdatesTemplate(@Step(number = 1, next = 2, name = "REST API call to create or update template", needsRestDoc = true))
-    @RequestMapping(path = "/template/{templateId}", method = RequestMethod.POST)
+    @RequestMapping(path = "/template/{templateId}", method = RequestMethod.PUT)
     @ResponseStatus(HttpStatus.OK)
     public void createOrUpdate(@RequestBody TemplateDefinition templateDefinition, @PathVariable("templateId") String templateId) {