Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accessibility #1994

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Conversation

Venkata-Sai-Vishwanath-robo
Copy link
Contributor

Description

This PR fixes #1992

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Dec 22, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 5ddf370
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6769a0306af540000838fc0e
😎 Deploy Preview https://deploy-preview-1994--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sudhanshutech
Copy link
Member

@Venkata-Sai-Vishwanath-robo
Thank you for your contribution!
Let's discuss this during the website call on Monday(today) at 6:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving Meshery.io to use e.code, @Venkata-Sai-Vishwanath-robo 👍

@@ -212,6 +212,7 @@

// adds toggle button to li items that have children
nav.find('li a').each(function() {
$(this).attr('tabindex', '0');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@leecalcote leecalcote merged commit dd148ff into meshery:master Jan 1, 2025
7 checks passed
Copy link

welcome bot commented Jan 1, 2025

Thanks for your contribution to the Layer5 and Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Accessibility: Enable TAB Navigation for Theme Toggle and Dropdown
3 participants