Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Fix: Modal Category Type Now Visible in Light/Dark Modes #2015

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Tharanishwaran
Copy link

@Tharanishwaran Tharanishwaran commented Jan 8, 2025

Description

This PR fixes #2010 #2017

Notes for Reviewers

Screenshot

Screenshot from 2025-01-08 15-01-41

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Jan 8, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 56453ad
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6786fa372fb13e0008d7a5ce
😎 Deploy Preview https://deploy-preview-2015--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Tharanishwaran <[email protected]>
@Tharanishwaran
Copy link
Author

Tharanishwaran commented Jan 8, 2025

Hi @vishalvivekm @sudhanshutech could you please review this PR and let me know if any changes are needed.

@aadarsh-nagrath
Copy link

looks good

Copy link
Contributor

@Touriist Touriist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tharanishwaran
There should be no effect on hover; it just needs to stay as a chip.

Also, I understand that the following may not be within the scope of the corresponding issue, but could you please take a look at fixing these two points:

  1. Modal's height:
    image

  2. the unwanted border:

image

@Tharanishwaran
Copy link
Author

Thank you for the feedback @Touriist. I will address the hover effect and modal fixes promptly.

@Tharanishwaran
Copy link
Author

Tharanishwaran commented Jan 12, 2025

@Touriist
I've fixed the unwanted border issue you pointed :
Screenshot from 2025-01-13 00-29-39


However, regarding the first issue about modal height . I'm unable to reproduce or see any height-related problems in the current version. Could you please provide more details.
Screenshot from 2025-01-13 00-19-41

@vishalvivekm
Copy link
Contributor

@Tharanishwaran
Thank you for your contribution!
Let's discuss this during the website call on Monday at 7 AM CT.

adding it as an agenda item to the meeting minutes.

@Tharanishwaran
Copy link
Author

Tharanishwaran commented Jan 15, 2025

@vishalvivekm
I have fixed the underline hover issue as well as the unwanted border issue in the theme toggle across the catalog, integrations, extensions, and brand sections.

Before Fix:

Screencast.2025-01-15.05.18.49.mp4

Screenshot from 2025-01-15 05-52-54

After Fix:

Screencast.2025-01-15.05.18.00.mp4

Screenshot from 2025-01-15 05-52-35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Modal Category type Hidden in Light/Dark Modes
4 participants