MBS-13872: Show primary alias in user tags and ratings #3432
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
added
the
Regression/Beta
mwiencek
reviewed
Jan 2, 2025
I had loaded aliases here for some cases, but not most - this should now cover all pages (user tag and user tag by entity, and user rating and user rating by entity).
This is a bit more clear and mirrors what these files already do for ACs.
Not yet changing uses of can('load_aliases') where we don't otherwise
use %ENTITIES since that's a less trivial change.
Seems I added this everywhere else that is relevant but forgot for artists
|
Added an extra commit fixing another place where I forgot to load aliases - artist merges :) |
mwiencek
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13872
I had loaded aliases here for some cases, but not most - this should now cover all pages (user tag and user tag by entity, and user rating and user rating by entity).
I also noticed while testing that I wasn't loading aliases on artist merge pages, so a separate commit does that now.
Testing
Manually, with
/user/reosarevok/tag/nyū%20myūjikku//user/reosarevok/tag/nyū%20myūjikku/artistand/user/dragonzeron/ratings//user/dragonzeron/ratings/artist- and by merging some artists with aliases.