Added option 'Remove perfect albums (allowing multiple file extensions)' #224
Conversation
…s)' which treats albums with mutiple complete sets of track files but with different extensions as perfect
| def callback(self, objs): | ||
| for album in objs: | ||
|
|
||
| if (not(isinstance(album, Album))): |
There was a problem hiding this comment.
You don't need to add parenthesis here:
if not isinstance(album, Album):|
|
||
| def callback(self, objs): | ||
| for album in objs: | ||
|
|
There was a problem hiding this comment.
This whiteline should be removed. See PEP8 for Python style recommendations.
| title = album.column('title') | ||
| log.info('Checking album perfection: %s', title) | ||
|
|
||
| if (album.loaded != True): |
There was a problem hiding this comment.
Useless parenthesis and test can be done this way:
if album.loaded:| continue | ||
|
|
||
| unsavedFiles = album.get_num_unsaved_files() | ||
| if (unsavedFiles > 0): |
| continue | ||
|
|
||
| unmatchedFiles = album.get_num_unmatched_files() | ||
| if (unmatchedFiles > 0): |
| #get dictionary of file extension counts | ||
| extDict = {} | ||
| for file in album.iterfiles(): | ||
| _, ext = os.path.splitext(file.filename) |
There was a problem hiding this comment.
Do not use _ as placeholder, it is used for translations (_() is a function), just use unused
|
@dsparkplug any update? |
|
IMO this is trying to do in a plugin what should be done in Picard proper i.e. because we need the icons to reflect the perfect nature of the album or otherwise - and this PR will essentially remove albums which are shown as needing saving in the UI. We need Picard to recognise perfect albums which have multiple formats. |
|
As this hasn't gone anywhere I'm going to close this for now. Can be re-opened if needed. And I agree with @Sophist-UK, we could at least have an option to treat a release with multiple files per track as completed. Maybe at least if each track has the same amount of files and they are of different formats. |
This option treats albums with multiple complete sets of track files but with different extensions as perfect.
See #222