-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally encode marked literals as MARC record attributes. #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is the solution for building the necessary structure, I think I now understand my (and @TobiasNx ) problem - it's just naming. Because the expression "attribute(Marker)" implicitly references all kind of "attributes" (i.a. the "tag" in "<marc:controlfield tag=...") and not only the "recordAttribute". But what is really meant is just the latter.
So I propose to change variable names and most importantly the API naming of "setAttributeMarker" to "setRecordAttributeMarker" (see https://www.loc.gov/standards/marcxml/xml/spy/spy.html).
This was initially meant as a feature, but if we consider it a bugfix, we can approach it differently: Encode |
But is there such a difference between the other attributes and the recordAttributes?
Are the fixed possible options for attributes in MarcXML. With such a limited number of options for attributes isn't it possible to recognise them straight as attributes as it is already done for most of them? |
Well, yes, there is a difference: All the other attributes are implementation details, so to speak. You don't pass a literal with |
May be superseded by #405. |
Superseded by #405, closing this one. |
This is a rather "dirty" fix. The "cleaner" solution would probably be to implement the same mechanism that
SimpleXmlEncoder
uses.Fixes #402.