Call LineRecorder receiver's closeStream() (#433) #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances (probably if the JVM is not stopped after processing) the streams of receivers connected to LineRecorder are not closed, resulting in empty or missing output data. - complement test
blackwinter
approved these changes
Dec 27, 2021
| @@ -81,7 +81,9 @@ public void resetStream() { | |||
|
|
|||
| @Override | |||
| public void closeStream() { | |||
| assert !isClosed(); | |||
There was a problem hiding this comment.
This is rather unusual. AFAICS, no other module does this (inside closeStream() that is).
There was a problem hiding this comment.
Do you really mean assert !isClosed(); ? There are alternatives like if (!isClosed) {. Does it make any difference, semantically? Would it be better to use the if statement?
There was a problem hiding this comment.
The assert means you can't (shouldn't) close a closed stream, while the conditional simply ignores an already closed stream. I think the latter behaviour would be preferable in general.
|
Closing this in favour of #435. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances (probably if the JVM is not stopped after processing)
the streams of receivers connected to LineRecorder are not closed, resulting
in empty or missing output data.
See #433.