Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add how to update and publish flux-commands.md #15

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Oct 15, 2021

In order of improving the documentation this should help to understand how to produce an improved flux-commands.md.

@dr0i dr0i requested a review from TobiasNx October 15, 2021 15:43
@TobiasNx
Copy link
Collaborator

Content looks good, but I don't think that this is the right spot to publish it.
Perhaps here?
https://github.com/metafacture/metafacture-core/wiki/Code-Quality-and-Style#code-documentation

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Oct 27, 2021
@dr0i
Copy link
Member Author

dr0i commented Nov 2, 2021

Hm, maybe - let's ask for opinion from @fsteeg.
My first thought was "flux-command.md is stored in this repo, so let's document here how to build it properly".

@dr0i dr0i assigned fsteeg and unassigned dr0i Nov 2, 2021
@fsteeg
Copy link
Member

fsteeg commented Nov 3, 2021

I think here is the right place, since it's published here.

(Also this is a temporary state, see metafacture/metafacture-core#368.)

@fsteeg fsteeg assigned dr0i and unassigned fsteeg Nov 3, 2021
@TobiasNx
Copy link
Collaborator

TobiasNx commented Nov 3, 2021

okay then go for it +1

@TobiasNx TobiasNx requested review from TobiasNx and removed request for TobiasNx November 3, 2021 09:14
@dr0i dr0i merged commit 90112e5 into master Nov 4, 2021
@dr0i
Copy link
Member Author

dr0i commented Nov 4, 2021

Also this is a temporary state

you mean "although".
If metafacture/metafacture-core#368 is ready resolved we could (should?) move this how-to to https://github.com/metafacture/metafacture.github.io/docs/main .

Merged for the time being and closed.

@dr0i dr0i deleted the addHowToUpdateFluxCommands branch November 4, 2021 07:54
@fsteeg
Copy link
Member

fsteeg commented Nov 4, 2021

you mean "although".

No, I meant it both in support of not moving it elsewhere (since it's temporary anyway), and as in "let me add that".

@dr0i
Copy link
Member Author

dr0i commented Nov 4, 2021

I don't understand. Let's clarify. What do you mean exactly by "this is a temporary state"? I thought you meant this repo (metafacture-documentation), while the future ordinary place would be in metafacture.github.io/docs/main . Or should the flux-commands.md be hold in two (three?) places - here and in metafacture.github.io/docs/main[releases...] ?

@fsteeg
Copy link
Member

fsteeg commented Nov 4, 2021

(Clarified in our meeting, we'll see where the file will be in the future, but for now it's good here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants