Integrate feedback from PR #87 (see #80, #82)

Co-authored-by: Jens Wille <[email protected]>
metafacture · Dec 9, 2021 · adb0693 · adb0693
1 parent fef37c2
commit adb0693
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/metafix/src/main/java/org/metafacture/metafix/Value.java b/metafix/src/main/java/org/metafacture/metafix/Value.java
@@ -273,9 +273,7 @@ void apply(final Hash hash, final String field, final String value) {
             INDEXED {
                 @Override
                 void apply(final Hash hash, final String field, final String value) {
-                    final Value newHash = newHash();
-                    newHash.asHash().put(field, new Value(value));
-                    hash.add(nextIndex(hash), newHash);
+                    hash.add(nextIndex(hash), newHash(h -> h.put(field, new Value(value))));
                 }
 
                 private String nextIndex(final Hash hash) {

diff --git a/metafix/src/test/java/org/metafacture/metafix/MetafixRecordTest.java b/metafix/src/test/java/org/metafacture/metafix/MetafixRecordTest.java
@@ -267,8 +267,7 @@ public void add() {
     @Test
     public void addWithAppendInArray() {
         MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
-                "add_field('names.$append','patrick')",
-                "vacuum()"),
+                "add_field('names.$append','patrick')"),
             i -> {
                 i.startRecord("1");
                 i.literal("names", "max");
@@ -288,8 +287,7 @@ public void addWithAppendInArray() {
     @Test
     public void addWithAppendInHash() {
         MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
-                "add_field('author.names.$append','patrick')",
-                "vacuum()"),
+                "add_field('author.names.$append','patrick')"),
             i -> {
                 i.startRecord("1");
                 i.startEntity("author");
@@ -312,8 +310,7 @@ public void addWithAppendInHash() {
     @Test
     public void addWithAppendInArrayWithSubfieldFromRepeatedField() {
         MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
-                "add_field('authors.$append.name','patrick')",
-                "vacuum()"),
+                "add_field('authors.$append.name','patrick')"),
             i -> {
                 i.startRecord("1");
                 i.startEntity("authors");
@@ -342,8 +339,7 @@ public void addWithAppendInArrayWithSubfieldFromRepeatedField() {
     @Test
     public void addWithAppendInArrayWithSubfieldFromIndexedArray() {
         MetafixTestHelpers.assertFix(streamReceiver, Arrays.asList(
-                "add_field('authors[].$append.name','patrick')",
-                "vacuum()"),
+                "add_field('authors[].$append.name','patrick')"),
             i -> {
                 i.startRecord("1");
                 i.startEntity("authors[]");