Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Convert marked array entity into actual array object. #109

Closed
blackwinter opened this issue Jan 19, 2022 · 0 comments · Fixed by #110
Closed

Convert marked array entity into actual array object. #109

blackwinter opened this issue Jan 19, 2022 · 0 comments · Fixed by #110
Assignees
@blackwinter

Comments

@blackwinter
Copy link
Member

When receiving an entity from upstream that is marked as an array (e.g. from JsonDecoder), convert it into an actual Value.Array object instead of having to deal with different array representations internally.

Related to #65 and #100; maybe also #95, #96 and #106.

Functional review: @TobiasNx? or: n/a (refactoring)
Code review: @fsteeg
@blackwinter blackwinter self-assigned this Jan 19, 2022
@blackwinter blackwinter mentioned this issue Jan 19, 2022
Closed
@blackwinter blackwinter changed the title Convert marked array to actual array object. Convert marked array entity to actual array object. Jan 19, 2022
blackwinter added a commit that referenced this issue Jan 19, 2022
@blackwinter
Produce Value.Array for marked array entities. (#109)
a42943d
blackwinter added a commit that referenced this issue Jan 19, 2022
@blackwinter
Require explicit array initialization. (#109)
7d9b2a4
@blackwinter blackwinter mentioned this issue Jan 19, 2022
Merged
@blackwinter blackwinter changed the title Convert marked array entity to actual array object. Convert marked array entity into actual array object. Jan 19, 2022
@TobiasNx TobiasNx mentioned this issue Mar 17, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blackwinter blackwinter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert marked array entity into actual array object. metafacture/metafacture-fix
1 participant
@blackwinter