Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Convert marked array entity into actual array object. #110

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

blackwinter
Copy link
Member

The last commit (7d9b2a4) might be debatable; but I feel making intentions explicit works in our favor for now (the usual WDCD applies, though).

Note that I deliberately went in the direction of more explicit types instead of less:

TODO? maybe this would be a good general internal representation, resulting
in every value being either a hash or a string, no more separate array type.

Resolves #109 and fixes most of the array issues in #100 (see 11d1e71).

@blackwinter blackwinter requested a review from fsteeg January 19, 2022 13:33
@blackwinter blackwinter changed the title Convert marked array entity to actual array object. Convert marked array entity into actual array object. Jan 19, 2022
Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Note to self & @TobiasNx: we'll probably have to add some set_array statements in OERSI & Playground samples when we deploy this.)

@fsteeg fsteeg assigned blackwinter and unassigned fsteeg Jan 20, 2022
@blackwinter blackwinter merged commit f1fcf99 into master Jan 20, 2022
@blackwinter blackwinter deleted the 109-convertMarkedArrayToObject branch January 20, 2022 12:26
@TobiasNx
Copy link
Collaborator

TobiasNx commented Jan 20, 2022

(Note to self & @TobiasNx: we'll probably have to add some set_array statements in OERSI & Playground samples when we deploy this.)

@blackwinter & @fsteeg.
Does this mean new created fields cannot be part of an array unless the array already exists?
e.g.:
add_field("ab.$append", "abc")

move_field("xy", "qr.$append.cd")

Is this conceptually not possible or just not realised yet?

@blackwinter
Copy link
Member Author

blackwinter commented Jan 20, 2022

Does this mean new created fields cannot be part of an array unless the array already exists?

Exactly.

Is this conceptually not possible or just not realised yet?

Intentionally not implemented (yet). Catmandu supports it, though, so maybe we should too?

tibdevelopment pushed a commit to TIBHannover/oersi-etl that referenced this pull request Jan 28, 2022
And add some now required `set_array` statements, see
metafacture/metafacture-fix#110
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert marked array entity into actual array object.
3 participants