Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Add flatten-function #122

Closed
TobiasNx opened this issue Feb 1, 2022 · 2 comments · Fixed by #244
Closed

Add flatten-function #122

TobiasNx opened this issue Feb 1, 2022 · 2 comments · Fixed by #244
Assignees
Labels
Enhancement New feature or request

Comments

@TobiasNx
Copy link
Collaborator

TobiasNx commented Feb 1, 2022

Flatten is not added as function.
It can be helpful if we have an array of keywords with some keywords connected and some tokenized.

in:

{
	"keywords": [
		"dog",
		"cat",
		"horse,bird,dragon"
	]
}

If we would split the third keyword we would (which we cannot at the moment) we would get an array in an array. Then flatten would be nice.

result (does not work yet because of the asterisk-problem with spli-field):

{
	"keywords": [
		"dog",
		"cat",
		["horse" , "bird" , "dragon"]
	]
}

should:

{
	"keywords": [
		"dog",
		"cat",
		"horse",
		"bird",
		"dragon"
	]
}

See test-scenario:
https://github.com/TobiasNx/fix-FunctionalReview-Testing/tree/master/data/testing/flattening

@TobiasNx TobiasNx added the Enhancement New feature or request label Feb 1, 2022
@blackwinter
Copy link
Member

Related to #100.

@fsteeg
Copy link
Member

fsteeg commented Feb 3, 2022

Will revisit after metafacture/metafacture-core#601.

@fsteeg fsteeg moved this to Backlog in Metafacture Feb 3, 2022
@TobiasNx TobiasNx changed the title Add flatten-function Add flatten-function Feb 8, 2022
TobiasNx added a commit that referenced this issue Mar 2, 2022
TobiasNx added a commit that referenced this issue Mar 3, 2022
blackwinter added a commit that referenced this issue Jul 12, 2022
@blackwinter blackwinter moved this from Backlog to Review in Metafacture Jul 12, 2022
TobiasNx added a commit that referenced this issue Jul 15, 2022
@TobiasNx TobiasNx assigned blackwinter and unassigned TobiasNx Jul 15, 2022
Repository owner moved this from Review to Done in Metafacture Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants