This repository has been archived by the owner on Jan 27, 2025. It is now read-only.
Add flatten() Fix function.
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackwinter
force-pushed
the
addFlattenFunction
branch
from
818d79c to
e044f86
Compare
fsteeg
approved these changes
Jul 14, 2022
|
+1 While testing I found a strange behavior with regard to the array-marker Don't know if this is connected to flatten or a general issue. |
This was referenced Jul 15, 2022
blackwinter
added a commit
that referenced
this pull request
Jul 15, 2022
Nested arrays would always be flattened: #244 (comment)
No, it's a general issue. It even worked with Metafix wasn't able to emit nested arrays properly (see #248 for a fix). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Catmandu's
flatten()function.Resolves #122.