This repository has been archived by the owner on Jan 27, 2025. It is now read-only.
Add Fix functions from Catmandu Cheat Sheet. #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackwinter
force-pushed
the
100-addFixFunctions
branch
from
00aca11 to
02fa712
Compare
Esp. for `uniq()` Fix function.
Esp. for `split_field()` Fix function.
blackwinter
force-pushed
the
100-addFixFunctions
branch
from
02fa712 to
abca2ef
Compare
blackwinter
added a commit
that referenced
this pull request
Jan 11, 2022
blackwinter
force-pushed
the
100-addFixFunctions
branch
from
863a9f4 to
3270490
Compare
This was referenced Jan 14, 2022
Merged
Closed
blackwinter
added a commit
that referenced
this pull request
Jan 18, 2022
blackwinter
force-pushed
the
100-addFixFunctions
branch
from
4850cbc to
e77188b
Compare
Do not just convert any value to string, but throw an exception instead when encountering an unexpected type.
Do not just treat any value as a list, but throw an exception instead when encountering an unexpected type.
fsteeg
approved these changes
Jan 21, 2022
| @@ -39,6 +39,8 @@ | |||
| private static final String CSV_MAP = "src/test/resources/org/metafacture/metafix/maps/test.csv"; | |||
| private static final String TSV_MAP = "src/test/resources/org/metafacture/metafix/maps/test.tsv"; | |||
|
|
|||
| private static final String LOOKUP = "lookup('title.*',"; | |||
There was a problem hiding this comment.
Minor: for tests, I often like to keep redundancies if they add clarity, to get kind of contained test cases.
There was a problem hiding this comment.
Well, what can I say? Got overpowered by my OCD ;)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opted for the non-destructive approach w.r.t.
Values. I don't think we're consistent as to when we modify an existing value and when we create a new one. Let me know if you have a preference - or if I'm mistaken and there's indeed a system to it ;)Omitted Fix functions from the cheat sheet:
assoc()diassoc()compact()(not applicable)flatten()from_json()to_json()uri_decode()uri_encode()Resolves #100.