Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Add and adjust integration test for lookup #211

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

TobiasNx
Copy link
Collaborator

@TobiasNx TobiasNx commented Mar 31, 2022

Related to:
metafix/src/test/java/org/metafacture/metafix/MetafixLookupTest.java

I added an integration test for test @blackwinter has added in context of #102

@@ -2,8 +2,14 @@
"animals" : [ "mammal", "bird", "fish" ]
}
{
"animals" : [ "human" ]
"animals" : [ "human", "bird", "fish" ] ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error.

Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the names of the two tests be swapped? lookupInArrayOfStringsDeleteNotMatchingValues has delete in its name, but not in the Fix. lookupInArrayOfStringsWithNotMatchingValues has delete in the Fix, but not in its name.

@blackwinter blackwinter assigned TobiasNx and unassigned blackwinter Mar 31, 2022
@TobiasNx TobiasNx force-pushed the lookupArrayOfStringsIntegrationTest branch from 884bd43 to 4263e4d Compare March 31, 2022 11:17
Related to:
metafix/src/test/java/org/metafacture/metafix/MetafixLookupTest.java
@TobiasNx TobiasNx force-pushed the lookupArrayOfStringsIntegrationTest branch from 4263e4d to adb8ebc Compare March 31, 2022 11:52
@TobiasNx
Copy link
Collaborator Author

TobiasNx commented Apr 1, 2022

I changed the folder names, @blackwinter. Can I merge now?

@blackwinter
Copy link
Member

Yes, I've already approved the pull request.

@TobiasNx TobiasNx merged commit 7021661 into master Apr 1, 2022
@TobiasNx TobiasNx deleted the lookupArrayOfStringsIntegrationTest branch April 1, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants