Skip to content
This repository has been archived by the owner on Jan 27, 2025. It is now read-only.

Remove Checkstyle @SuppressWarnings, disable for tests #76

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Nov 17, 2021

Will resolve #62.

@blackwinter
Copy link
Member

blackwinter commented Nov 17, 2021 via email

@fsteeg
Copy link
Member Author

fsteeg commented Nov 18, 2021

  1. I assumed we would only disable specific checks for the tests.

I did look into that again yesterday, but there seems to be no straightforward way to do that. One option would be to have separate configs for main and test, but that would duplicate a lot. As mentioned in #62 (comment) and in our meeting, I think that was my reason to introduce annotation support, as it provides a convenient way to disable specific checks for a file / class. But I'm not picky here, it would all be fine with me: duplicate / separate configs, off for all tests (current state), or some proper setup in Checkstyle that I didn't find / get.

  1. The Checkstyle config for the annotation should be removed if it's no longer used.

Right, thanks. After removing it, I also found missing annotations that didn't match my simple search pattern (multiple checks disabled). Pushed both in 632802a.

@blackwinter
Copy link
Member

blackwinter commented Nov 18, 2021 via email

@fsteeg
Copy link
Member Author

fsteeg commented Nov 18, 2021

Oh, right, thanks, how did I not find that? Pushed in ea789ff.

@blackwinter
Copy link
Member

blackwinter commented Nov 18, 2021 via email

@fsteeg fsteeg merged commit 6e3d4c4 into master Nov 18, 2021
@fsteeg fsteeg deleted the 62-checkstyleSuppression branch November 18, 2021 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agree on a single Checkstyle suppression mechanism
2 participants