Simplify how sounds are queued.

meth-meth-method · Feb 19, 2020 · 5c8e2bf · 5c8e2bf
1 parent bcb8141
commit 5c8e2bf
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/public/js/Entity.js b/public/js/Entity.js
@@ -13,6 +13,7 @@ export class Trait {
     constructor(name) {
         this.NAME = name;
 
+        this.sounds = new Set();
         this.tasks = [];
     }
 
@@ -33,6 +34,14 @@ export class Trait {
 
     }
 
+    playSounds(audioBoard, audioContext) {
+        this.sounds.forEach(name => {
+            audioBoard.playAudio(name, audioContext);
+        });
+
+        this.sounds.clear();
+    }
+
     update() {
 
     }
@@ -81,6 +90,7 @@ export default class Entity {
     update(gameContext, level) {
         this.traits.forEach(trait => {
             trait.update(this, gameContext, level);
+            trait.playSounds(this.audio, gameContext.audioContext);
         });
 
         this.lifetime += gameContext.deltaTime;

diff --git a/public/js/traits/Jump.js b/public/js/traits/Jump.js
@@ -34,12 +34,11 @@ export default class Jump extends Trait {
         }
     }
 
-
     update(entity, gameContext, level) {
         const deltaTime = gameContext.deltaTime;
         if (this.requestTime > 0) {
             if (this.ready > 0) {
-                entity.audio.playAudio('jump', gameContext.audioContext);
+                this.sounds.add('jump');
                 this.engageTime = this.duration;
                 this.requestTime = 0;
             }

diff --git a/public/js/traits/Stomper.js b/public/js/traits/Stomper.js
@@ -27,9 +27,9 @@ export default class Stomper extends Trait {
         }
     }
 
-    update(entity, {audioContext}) {
+    update(entity) {
         if (this.didStomp) {
-            entity.audio.playAudio('stomp', audioContext);
+            this.sounds.add('stomp');
             this.didStomp = false;
         }
     }