Add linewidth 1 + no sub pixel rendering. #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomle
requested changes
Jun 17, 2020
public/js/layers/collision.js
Outdated
| @@ -1,13 +1,14 @@ | |||
| function createEntityLayer(entities) { | |||
| return function drawBoundingBox(context, camera) { | |||
| context.strokeStyle = 'red'; | |||
| context.lineWidht = 1; | |||
There was a problem hiding this comment.
This is spelled wrong. Don't think it is needed.
bouveng
force-pushed
the
fix-boundingbox-collision-layer
branch
27 times, most recently
from
91faafb to
fc4f006
Compare
bouveng
force-pushed
the
fix-boundingbox-collision-layer
branch
17 times, most recently
from
6e956b3 to
c330c3d
Compare
bouveng
force-pushed
the
fix-boundingbox-collision-layer
branch
from
c330c3d to
a24a4a4
Compare
|
Created new PR #123 , could not get out of git hell after 44 force pushes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make bounding box lines 1px and remove sub pixel rendering.
In order for collision layer to be useful it needs to be exact.