Fix backwards compatibility #355
Conversation
|
Nice catch. Is there an Travis build failed for this reason? |
|
But why do we want to support ruby 2.0.0-p594? CentOS' ruby version is 2.0.0-p598. Also, I believe the previous code had been already adapted to work on the CentOS version, as the comment said. Is that code failing for version 2.1.5? |
rafamanzo
force-pushed
the
fix_backwards_compatibility
branch
from
3f487f1 to
44295af
Compare
|
I think that modification (which put the comment) fixed the build you are referring to, @dread-uo. Note that the build is from this commit: cb40650 If you browse the code using that commit as the HEAD, you'll see that that file used a fancy ruby syntax: https://github.com/mezuro/prezento/blob/cb40650003dd9ef0de905e2833ff66afb9c43b2e/features/support/header.rb That was fixed afterwards by this commit which, in turn, was part of this PR. As you can see there, all checks were successful before it was accepted. 😄 |
|
Still how does this build passes? https://travis-ci.org/mezuro/prezento/builds/132892500 Maybe the fail you mentioned has been fixed indirectly. Do you think this MR is still necessary? |
|
I'm the fastest gun in all Mezuro's organization, @rafamanzo 🔫 |
|
I got confused by all those failing/passing builds, sorry for that! Anyway, it seems like both ways work. If you choose to use this PR's syntax, we can change the commit message. I won't be sad if you choose to simply close this either, as the builds are ok without it. |
|
I agree your syntax is clearer. Could you just restore the comment? And change the commit message in order to reflect its new purpose? |
rafamanzo
force-pushed
the
fix_backwards_compatibility
branch
from
f6627f1 to
7d01c5c
Compare
The previous syntax was over complicated. This one gets the job done the same way. Signed-off-by: Rafael Reggiani Manzo <[email protected]>
rafamanzo
force-pushed
the
fix_backwards_compatibility
branch
from
7d01c5c to
fbbd28b
Compare
No description provided.