Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes main content width (Closes #367) #376

Merged
merged 2 commits into from
Sep 29, 2016

Conversation

DylanGuedes
Copy link
Contributor

  • Uses bootstrap container to enclose main content
  • Adds dinamic stick footer. (mainly an enhancement for short pages)

<div class="row">
<div class="col-md-3"><%= link_to(image_tag('agplv3-88x31.png'), 'http://www.gnu.org/licenses/agpl-3.0-standalone.html') %></div>
<div class="col-md-3"><%= link_to image_tag('fork-me.png'), 'https://github.com/mezuro/prezento' %></div>
<div class="col-md-3"><%= image_tag 'usp-cloud-nuvem-logo.png' %></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should take this opportunity to remove this logo (we were kicked out of there).

@rafamanzo
Copy link
Member

Are the footer changes related to modifying the main content width? They are indeed nice but keep in mind this comment from a previous PR: #370 (comment)

@rafamanzo
Copy link
Member

Does the bootstrap container class provide the width limitation proposed by #367?

@DylanGuedes
Copy link
Contributor Author

The footer changes are not related, but there's no issue for them and I thought that It was a nice addition - I can separate it in other merge request if you want.

About the width, I preferred to use the default bootstrap container (it isn't 72% I guess), because it works better for multiple resolutions (it's dinamic) than using 72% for every resolution (for a phone, for example, maybe a value higher than 72% looks better).

But I can use the fixed 72% width, if you think that it's better.

@rafamanzo
Copy link
Member

If you rebase from master and remove that image from the footer I believe we are good to go.

@DylanGuedes
Copy link
Contributor Author

Done.

@diegoamc
Copy link
Contributor

Something odd is happening with the cucumber jobs for ruby 2.3.0. It seems poltergeist cannot be found. @DylanGuedes, is this something that happens on your local machine too?

@DylanGuedes
Copy link
Contributor Author

In my local it looks ok, actually. :/
And I checked that the MRs opened by my friends are also broken for the same reason (something relative to capybara poltergeist missing).

@DylanGuedes DylanGuedes reopened this Sep 27, 2016
@rafamanzo rafamanzo merged commit 246f2eb into mezuro:master Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants