Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor a few modules to use has_owner concern #382

Merged
merged 1 commit into from
Oct 3, 2016
Merged

Refactor a few modules to use has_owner concern #382

merged 1 commit into from
Oct 3, 2016

Conversation

DylanGuedes
Copy link
Contributor

  • Creates new concern call'd "HasOwner", that is usable in entities that belongs to users and can be private/public (for example: projects, repositories, and a few others)
  • Refactor few classes to use the HasOwner concern - The classes are: "Project", "KalibroConfiguration", "ReadingGroup" and "Repository"

@DylanGuedes
Copy link
Contributor Author

Obs: I don't created tests because I don't added any functionality or altered behaviour - It's just rewrite.

@rafamanzo
Copy link
Member

Nice job.

@rafamanzo rafamanzo merged commit a5f2d20 into mezuro:master Oct 3, 2016
@wiltonsr wiltonsr mentioned this pull request Oct 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanGuedes @rafamanzo