Multiple attributes validates#244 #386
Conversation
|
From what I understood, is that? @rafamanzo |
jonnatas
force-pushed
the
MultipleAttributesValidates#244
branch
from
153da8b to
3a21d91
Compare
| @@ -6,6 +6,7 @@ The version numbers below try to follow the conventions at http://semver.org/. | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - Adding validades with presence uniqueness of ids | |||
There was a problem hiding this comment.
What do you think about: Adds validations (presence and uniqueness) of foreign keys?
| @@ -1,6 +1,6 @@ | |||
| class ProjectAttributes < ActiveRecord::Base | |||
| belongs_to :user | |||
| validates :project_id, presence: true | |||
| validates :project_id, presence: true, uniqueness: { scope: :user_id} | |||
There was a problem hiding this comment.
It limits the scope in which uniqueness checking occurs, i.e., in this example, the project_id may repeat if the user_id is different. You think better cut this scope?
There was a problem hiding this comment.
Thinking about this once more I don't believe we want to allow multiple project owners for now. Allowing that kind of behaviour may lead to expectations about features we do not yet implement (such as adding members to the project).
So maybe it's better to leave the scope out.
| @@ -1,6 +1,6 @@ | |||
| class RepositoryAttributes < ActiveRecord::Base | |||
| belongs_to :user | |||
| validates :repository_id, presence: true | |||
| validates :repository_id, presence: true, uniqueness: { scope: :user_id} | |||
There was a problem hiding this comment.
Thinking about this once more I don't believe we want to allow multiple project owners for now. Allowing that kind of behaviour may lead to expectations about features we do not yet implement (such as adding members to the project).
So maybe it's better to leave the scope out.
jonnatas
force-pushed
the
MultipleAttributesValidates#244
branch
from
3a21d91 to
609ac02
Compare
jonnatas
force-pushed
the
MultipleAttributesValidates#244
branch
from
609ac02 to
2aa83f5
Compare
jonnatas
force-pushed
the
MultipleAttributesValidates#244
branch
from
2aa83f5 to
6fb9480
Compare
jonnatas
force-pushed
the
MultipleAttributesValidates#244
branch
from
6fb9480 to
e2e4cd9
Compare
isuue #244