Replace webrick by puma #393
Conversation
| @@ -81,7 +81,7 @@ group :test do | |||
| gem 'codeclimate-test-reporter', require: nil | |||
|
|
|||
| # For Konacha | |||
| gem 'thin' | |||
| gem 'puma' | |||
There was a problem hiding this comment.
I think we want puma to be used on all environments, not only test.
| @@ -0,0 +1,5 @@ | |||
| describe KalibroModule, :type => :model do | |||
There was a problem hiding this comment.
We have added this test but now we see that isn't necessary.
For some reason this module was lowering the coverage.
We already removed it.
|
Is this PR meant to replace #387? If so, you are missing the changes on the |
|
Could you see what error is happening in Travis? This error doesn't occur in local environment when I execute the server, all test in |
|
The error message says:
Could you try increasing |
|
I've tried this. Setting from 20s to 60s. But it did not work |
|
ping |
Replacing gem thin by puma. In konacha configuration file was made substitution of application server. Signed-off-by: Wilton Rodrigues <[email protected]> Signed-off-by: MatheusFerraz <[email protected]>
|
I am able to reproduce the CI issues on my local environment today by running I've tried updating the gems for poltergeist (1.12.0), konacha (4.0.0) and puma (3.6.2) to no success. I'll try replacing konacha by teaspoon. It have worked on other project I've worked when we had issues regarding Rails 5 compatibility. Not related at all, but may work. |
|
We are closing this PR in favor of #405, reopen if needed. |
In konacha configuration file was made substitution of application server.
Signed-off-by: Wilton Rodrigues [email protected]
Signed-off-by: MatheusFerraz [email protected]