Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling unsupported format requests with error page #400

Merged
merged 2 commits into from
Apr 13, 2017

Conversation

vitorbaraujo
Copy link
Contributor

@vitorbaraujo vitorbaraujo commented Apr 6, 2017

  • Rescuing ActionView::MissingTemplate with not_found method located in app/controllers/application_controller.rb
  • Modifying not_found method to render page telling that format given is unsupported
  • Updating related tests

This PR closes #301

Signed-off-by: Kassia Catarine <[email protected]>
Signed-off-by: Vitor Barbosa <[email protected]>
@vitorbaraujo vitorbaraujo force-pushed the handle_unsupported_format_requests branch from 1157bd3 to 7cd0336 Compare April 11, 2017 20:20
Signed-off-by: Vitor Barbosa <[email protected]>
Signed-off-by: Kassia Catarine <[email protected]>
@vitorbaraujo vitorbaraujo force-pushed the handle_unsupported_format_requests branch from 7cd0336 to 9e3480a Compare April 11, 2017 20:21
@rafamanzo
Copy link
Member

Nice modifications!

I have a few good practice advises for your future contributions:

  • It has been some time that we've adopted some rules for commit messages (https://chris.beams.io/posts/git-commit/#seven-rules) that have been really helpful for us on understanding modifications both for revision and bugfix purposes
  • I see you have fixed more than just Handle unsupported format requests #301 by modifying the Gemfile. That's a nice fix, but have in mind to make it a separate PR in the future. This makes review easier and allow more code to reach the master faster

Welcome and thanks for the nice work!

@rafamanzo rafamanzo merged commit 8c46618 into mezuro:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle unsupported format requests
2 participants