Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdr.Resampler polyphase rational resampler #138

Merged
merged 8 commits into from
Nov 12, 2023

Conversation

mhostetter
Copy link
Owner

No description provided.

In linear interpolation, MATLAB makes the first output sample advance, not align on the first input sample. I changed to be more consistent with MATLAB to prepare for supporting polyphase rational resampling.
This enables the "better" interpolation method, while allowing users to use MATLAB's method.
Fixes Add `sdr.MultirateFIR` #33
@mhostetter mhostetter added the dsp Related to digital signal processing routines label Nov 12, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/sdr/_filter/_polyphase.py 70.70% <71.11%> (-2.73%) ⬇️

📢 Thoughts on this report? Let us know!

@mhostetter mhostetter merged commit 1d9a554 into release/0.0.x Nov 12, 2023
26 checks passed
@mhostetter mhostetter deleted the mhostetter/issue33 branch November 12, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dsp Related to digital signal processing routines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants